HAM/Berufsschule_HAM
1
0
Fork 1
mirror of https://github.com/LD-Reborn/Berufsschule_HAM.git synced 2025-12-20 06:51:55 +00:00
Code Issues Packages Projects 1 Releases Wiki Activity

Merge pull request #221 from LD-Reborn/220-bug-users-view-loads-slowly-because-of-unneeded-ldap-properties

Browse Source 
Fixed performance issue related to user model retrieval, cleaned up L…
This commit is contained in:
LD50
2025-11-01 16:59:52 +01:00
committed by GitHub
parent c9d2be3542 4b3ad38cc3
commit 2adbcc5dde
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Controllers/HomeController.cs
View File

@@ -77,7 +77,7 @@ public class HomeController : Controller
[HttpGet("Users")] [HttpGet("Users")]
public async Task<ActionResult> UsersAsync() public async Task<ActionResult> UsersAsync()
{ {
IEnumerable<UserModel> users = await _ldap.ListUsersAsync(); IEnumerable<UserModel> users = await _ldap.ListUsersAsync([.. _ldap.UsersAttributes.Where(attr => attr != "jpegPhoto" && attr != "userPassword")]);
List<UserTableViewModel> UserTableViewModels = []; List<UserTableViewModel> UserTableViewModels = [];
foreach (UserModel user in users) foreach (UserModel user in users)
{ {

5
src/Services/LdapService.cs
View File

@@ -77,10 +77,7 @@ public partial class LdapService : IDisposable
public async Task<IEnumerable<UserModel>> ListUsersAsync() public async Task<IEnumerable<UserModel>> ListUsersAsync()
{ {
IEnumerable<Dictionary<string, string>> users = await ListObjectBy(UsersBaseDn, "", UsersAttributes); return await ListUsersAsync(UsersAttributes);
List<UserModel> models = [];
users.ToList().ForEach(x => models.Add(new UserModel(x) {Uid = x["uid"]}));
return models;
} }
public async Task<MigrationModel> GetMigrationVersionAsync() public async Task<MigrationModel> GetMigrationVersionAsync()