From 8a8964a08c339a4b54bde2c26bd571309fcc72e4 Mon Sep 17 00:00:00 2001
From: LD-Reborn <lucretia.dietz@gmx.de>
Date: Sat, 29 Nov 2025 13:13:26 +0100
Subject: [PATCH] Removed tabindices for non-interactive elements

---
 src/Views/Home/Groups.cshtml    | 4 ++--
 src/Views/Home/Locations.cshtml | 4 ++--
 src/Views/Home/Users.cshtml     | 4 ++--
 src/Views/Settings/Admin.cshtml | 2 +-
 src/Views/Shared/_Batch.cshtml  | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/Views/Home/Groups.cshtml b/src/Views/Home/Groups.cshtml
index 2ac3fbc..34cda84 100644
--- a/src/Views/Home/Groups.cshtml
+++ b/src/Views/Home/Groups.cshtml
@@ -38,7 +38,7 @@
                 foreach (GroupsTableViewModel groupTableViewModel in Model.GroupsTableViewModels)
                 {
                 <tr>
-                    <td class="text-center" tabindex="0">@groupTableViewModel.Group</td>
+                    <td class="text-center">@groupTableViewModel.Group</td>
                     <td class="text-center @(groupTableViewModel.CanInventorize ? "text-success" : "text-danger")"><span class="visually-hidden">@T["inventorize"]</span>@(groupTableViewModel.CanInventorize ? Html.Raw($"<span aria-hidden=\"true\">✓</span><span class=\"visually-hidden\">{@T["Yes"].Value}</span>") : Html.Raw($"<span aria-hidden=\"true\">✗</span><span class=\"visually-hidden\">{@T["No"].Value}</span>"))</td>
                     <td class="text-center @(groupTableViewModel.CanManageUsers ? "text-success" : "text-danger")"><span class="visually-hidden">@T["manage users"]</span>@(groupTableViewModel.CanManageUsers ? Html.Raw($"<span aria-hidden=\"true\">✓</span><span class=\"visually-hidden\">{@T["Yes"].Value}</span>") : Html.Raw($"<span aria-hidden=\"true\">✗</span><span class=\"visually-hidden\">{@T["No"].Value}</span>"))</td>
                     <td class="text-center @(groupTableViewModel.CanManageLocations ? "text-success" : "text-danger")"><span class="visually-hidden">@T["manage locations"]</span>@(groupTableViewModel.CanManageLocations ? Html.Raw($"<span aria-hidden=\"true\">✓</span><span class=\"visually-hidden\">{@T["Yes"].Value}</span>") : Html.Raw($"<span aria-hidden=\"true\">✗</span><span class=\"visually-hidden\">{@T["No"].Value}</span>"))</td>
@@ -268,7 +268,7 @@
                     const tableBody = document.querySelector('tbody');
                     const newRow = document.createElement('tr');
                     newRow.innerHTML = `
-                        <td class="text-center" tabindex="0">${jsonData.DisplayName}</td>
+                        <td class="text-center">${jsonData.DisplayName}</td>
                         <td class="text-center ${jsonData.Permissions.includes("CanInventorize") ? "text-success" : "text-danger"}"><span class="visually-hidden">@T["inventorize"]</span>${jsonData.Permissions.includes("CanInventorize") ? contentYes : contentNo}</td>
                         <td class="text-center ${jsonData.Permissions.includes("CanManageUsers") ? "text-success" : "text-danger"}"><span class="visually-hidden">@T["manage users"]</span>${jsonData.Permissions.includes("CanManageUsers") ? contentYes : contentNo}</td>
                         <td class="text-center ${jsonData.Permissions.includes("CanManageLocations") ? "text-success" : "text-danger"}"><span class="visually-hidden">@T["manage locations"]</span>${jsonData.Permissions.includes("CanManageLocations") ? contentYes : contentNo}</td>
diff --git a/src/Views/Home/Locations.cshtml b/src/Views/Home/Locations.cshtml
index 8aeba0d..258a571 100644
--- a/src/Views/Home/Locations.cshtml
+++ b/src/Views/Home/Locations.cshtml
@@ -40,7 +40,7 @@
                 foreach (LocationTableViewModel locationTableViewModel in Model.LocationTableViewModels)
                 {
                 <tr>
-                    <td tabindex="0">@locationTableViewModel.LocationID</td>
+                    <td>@locationTableViewModel.LocationID</td>
                     <td>@locationTableViewModel.LocationName</td>
                     <td>@locationTableViewModel.RoomNumber</td>
                     <td>@locationTableViewModel.Seat</td>
@@ -344,7 +344,7 @@
                     const tbody = document.querySelector('table tbody');
                     const newRow = document.createElement('tr');
                     newRow.innerHTML = `
-                        <td tabindex="0">${slugifiedLocationID}</td>
+                        <td>${slugifiedLocationID}</td>
                         <td>${newLoc.Location}</td>
                         <td>${newLoc.RoomNumber}</td>
                         <td>${newLoc.Seat}</td>
diff --git a/src/Views/Home/Users.cshtml b/src/Views/Home/Users.cshtml
index adb1458..238842f 100644
--- a/src/Views/Home/Users.cshtml
+++ b/src/Views/Home/Users.cshtml
@@ -43,7 +43,7 @@
                     <td>
                     <img class="rounded-circle user-icon" src="~/Home/UserPhoto?uid=@userTableViewModel.Uid&size=48" alt="Photo" style="width:32px;height:32px;" width="32" height="32" loading="lazy" />
                     </td>
-                    <td tabindex="0">@userTableViewModel.Uid</td>
+                    <td>@userTableViewModel.Uid</td>
                     <td>@userTableViewModel.Title</td>
                     <td>@userTableViewModel.Name</td>
                     <td>@userTableViewModel.Surname</td>
@@ -562,7 +562,7 @@
                     const newRow = document.createElement('tr');
                     newRow.innerHTML = `
                         <td><img class="rounded-circle user-icon" src="/Home/UserPhoto?uid=${result.Uid}&size=48" alt="Photo" style="max-width:300px;" /></td>
-                        <td tabindex="0">${result.Uid || ''}</td>
+                        <td>${result.Uid || ''}</td>
                         <td>${data.Title || ''}</td>
                         <td>${data.Cn || ''}</td>
                         <td>${data.Sn || ''}</td>
diff --git a/src/Views/Settings/Admin.cshtml b/src/Views/Settings/Admin.cshtml
index c52a9bb..3847318 100644
--- a/src/Views/Settings/Admin.cshtml
+++ b/src/Views/Settings/Admin.cshtml
@@ -68,7 +68,7 @@
             </select>
         </div>
         <div class="col-md-4">
-            <p tabindex="0" class="form-label">@T["Current user image cache utilization:"] <span id="userImageCacheSize">@userImageCacheSize</span></p>
+            <p class="form-label">@T["Current user image cache utilization:"] <span id="userImageCacheSize">@userImageCacheSize</span></p>
             <button class="form-control btn btn-danger" type="button" id="clearCacheBtn">@T["Clear user image cache"]</button>
         </div>
     </div>
diff --git a/src/Views/Shared/_Batch.cshtml b/src/Views/Shared/_Batch.cshtml
index c6adfc6..c7e14af 100644
--- a/src/Views/Shared/_Batch.cshtml
+++ b/src/Views/Shared/_Batch.cshtml
@@ -68,7 +68,7 @@
                     assetCard.innerHTML = `
                         <div class="card-body" data-cn="${asset.Cn}">
                             <span>
-                                <h4 tabindex="0" class="card-title mb-4" style="text-align: center;"><strong aria-label="Asset ${i + 1}: ${asset.Name}">Asset ${i + 1}:</strong> ${asset.Name}</h4>
+                                <h4 class="card-title mb-4" style="text-align: center;"><strong aria-label="Asset ${i + 1}: ${asset.Name}">Asset ${i + 1}:</strong> ${asset.Name}</h4>
                                 <button class="btn btn-sm btn-danger" data-action="remove" data-batchid="${i}" aria-label="@T["Delete entry"]" style="float:left;">X</button>
                             </span>
                             <div class="row">
@@ -91,7 +91,7 @@
                     assetCard.innerHTML = `
                         <div class="card-body">
                             <span>
-                                <h4 tabindex="0" class="card-title mb-4" style="text-align: center;"><strong aria-label="Asset ${i + 1}: @T["Empty"]">Asset ${i + 1}:</strong> @T["Empty"]</h4>
+                                <h4 class="card-title mb-4" style="text-align: center;"><strong aria-label="Asset ${i + 1}: @T["Empty"]">Asset ${i + 1}:</strong> @T["Empty"]</h4>
                                 <button class="btn btn-sm btn-danger" data-action="remove" data-batchid="${i}" aria-label="@T["Delete entry"]" style="float:left;">X</button>
                             </span>
                             <div class="row">