From caa1c7b1704bf2945fa029e2aba1f41a247f12f0 Mon Sep 17 00:00:00 2001
From: LD-Reborn <lucretia.dietz@gmx.de>
Date: Mon, 10 Nov 2025 00:49:09 +0100
Subject: [PATCH] Replaced unreliable sleeps in TryRetryFindSuccessToast

---
 .../Helper/AppHelper.cs                       | 34 ++++---------------
 1 file changed, 7 insertions(+), 27 deletions(-)

diff --git a/tests/Berufsschule_HAM.E2ETests/Helper/AppHelper.cs b/tests/Berufsschule_HAM.E2ETests/Helper/AppHelper.cs
index b7e593c..eaacf45 100644
--- a/tests/Berufsschule_HAM.E2ETests/Helper/AppHelper.cs
+++ b/tests/Berufsschule_HAM.E2ETests/Helper/AppHelper.cs
@@ -74,33 +74,8 @@ public static class AppHelper
 
     public static bool TryRetryFindSuccessToast(ChromeDriver driver)
     {
-        int retryCounter = 0;
-        retry:
-        try
-        {
-
-            IWebElement successToast = driver.FindElement(By.CssSelector("#toastContainer div.bg-success"));
-            if (successToast.Displayed)
-            {
-                return true;
-            }
-        }
-        catch (Exception) { }
-        try
-        {
-            IWebElement failToast = driver.FindElement(By.CssSelector("#toastContainer div.bg-danger"));
-            if (failToast.Displayed)
-            {
-                return false;
-            }
-        }
-        catch (Exception) { }
-        if (++retryCounter < 5)
-        {
-            Thread.Sleep(250);
-            goto retry;
-        }
-        return false;
+        Timeout(driver).Until(ExpectedConditions.ElementIsVisible(By.CssSelector("#toastContainer div.bg-success")));
+        return true;
     }
 
     public static bool CheckboxGetState(IWebElement webElement)
@@ -142,4 +117,9 @@ public static class AppHelper
     {
         return new(driver, TimeSpan.FromSeconds(DefaultTimeout));
     }
+
+    public static string GetRandomName()
+    {
+        return new string([.. Enumerable.Range(0, 8).Select(_ => (char)('a' + new Random().Next(26)))]);
+    }
 }
\ No newline at end of file