HAM/Berufsschule_HAM
1
0
Fork 1
mirror of https://github.com/LD-Reborn/Berufsschule_HAM.git synced 2025-12-20 06:51:55 +00:00
Code Issues Packages Projects 1 Releases Wiki Activity

Replaced unreliable sleeps with WebDriverWait

Browse Source
This commit is contained in:
LD-Reborn
2025-11-10 00:29:36 +01:00
parent 53645a4b7e
commit fb15d825d0
6 changed files with 35 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/Berufsschule_HAM.E2ETests/Helper/GroupsHelper.cs
View File

@@ -3,6 +3,7 @@ using System.Net;
using OpenQA.Selenium;
using OpenQA.Selenium.Chrome;
using OpenQA.Selenium.Support.UI;
using SeleniumExtras.WaitHelpers;
namespace Berufsschule_HAM.E2ETests.Helper;
@@ -13,7 +14,7 @@ public static class GroupsHelper
NavigateToGroupsPage(driver);
IWebElement createGroupButton = driver.FindElement(By.CssSelector("button[data-bs-target=\"#createGroupModal\"]"));
createGroupButton.Click();
Thread.Sleep(500);
AppHelper.AwaitVisible(driver, By.Id("cn"));
driver.FindElement(By.Id("cn")).SendKeys(cn);
driver.FindElement(By.Id("displayname")).SendKeys(displayName);
if (canInventorize) driver.FindElement(By.Id("canInventorize")).Click();
@@ -32,7 +33,7 @@ public static class GroupsHelper
NavigateToGroupsPage(driver);
IWebElement updateGroupButton = driver.FindElement(By.CssSelector($"button[data-group-id=\"{cn}\"].btn-update"));
AppHelper.ScrollIntoViewAndClick(driver, updateGroupButton);
Thread.Sleep(500);
AppHelper.AwaitVisible(driver, By.CssSelector("input#groupId"));
var cnInput = driver.FindElement(By.CssSelector("input#groupId"));
cnInput.Click();
cnInput.Clear();
@@ -69,7 +70,7 @@ public static class GroupsHelper
NavigateToGroupsPage(driver);
IWebElement deleteButton = driver.FindElement(By.CssSelector($"button[data-group-id=\"{cn}\"].btn-delete"));
AppHelper.ScrollIntoViewAndClick(driver, deleteButton);
Thread.Sleep(1000);
AppHelper.AwaitVisible(driver, By.Id("deleteModal"));
driver.FindElement(By.Id("deleteModal"));
IWebElement deleteConfirmButton = driver.FindElement(By.CssSelector("#deleteModal .btn-danger"));
deleteConfirmButton.Click();